[workspace] Deprecate public use of several externals #18690
Conversation
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-release please |
|
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-snopt-mosek-release please |
|
+@sammy-tri for both reviews per schedule, please (Thursday is fine). I'm doing a bit of review-balancing to share the load and broaden the understanding of the build-system-internal work. |
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee sammy-tri(platform) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/workspace/suitesparse_internal/package.BUILD.bazel line 14 at r1 (raw file):
cc_library( name = "config", srcs = ["SuiteSparse_config/SuiteSparse_config.c"],
Working
I missed the hidden here.
Add a suitesparse_internal repository to rebuild (the AMD part of) SuiteSparse from source with hidden visibility. Remove SuiteSparse from the host and wheel dependencies. Deprecate the public (host) suitesparse external. Rename OSQP, QDLDL, SCS to use the "_internal" suffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)
jwnimmer-tri
force-pushed
the
workspace-suitesparse
branch
from
ee9ed60 to
2ebcb82
Compare
There was a problem hiding this comment.
Reviewable status:
tools/workspace/suitesparse_internal/package.BUILD.bazel line 14 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
I missed the
hiddenhere.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
…n#18690) Add a suitesparse_internal repository to rebuild (the AMD part of) SuiteSparse from source with hidden visibility. Remove SuiteSparse from the host and wheel dependencies. Deprecate the public (host) suitesparse external. Rename OSQP, QDLDL, SCS to use the "_internal" suffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)
…n#18690) Add a suitesparse_internal repository to rebuild (the AMD part of) SuiteSparse from source with hidden visibility. Remove SuiteSparse from the host and wheel dependencies. Deprecate the public (host) suitesparse external. Rename OSQP, QDLDL, SCS to use the "_internal" suffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)
…n#18690) Add a suitesparse_internal repository to rebuild (the AMD part of) SuiteSparse from source with hidden visibility. Remove SuiteSparse from the host and wheel dependencies. Deprecate the public (host) suitesparse external. Rename OSQP, QDLDL, SCS to use the "_internal" suffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)
…n#18690) Add a suitesparse_internal repository to rebuild (the AMD part of) SuiteSparse from source with hidden visibility. Remove SuiteSparse from the host and wheel dependencies. Deprecate the public (host) suitesparse external. Rename OSQP, QDLDL, SCS to use the "_internal" suffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)
Add a
@suitesparse_internalrepository to rebuild (the AMD part of) SuiteSparse from source, with hidden visibility.Deprecate the public (host)
@suitesparseexternal. Remove suitesparse from our OS dependencies.Rename OSQP, QDLDL, SCS to use the
_internalsuffix and deprecate their non-internal spellings. (They are all C libraries that already use hidden visibility, so they don't need any C++ vendoring changes to their BUILD.)Towards #17231.
This change is